This repository was archived by the owner on Aug 1, 2024. It is now read-only.
chore: Update MySQL container to use edxops/mysql:5.7 container image #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@NIXKnight this seems to work on M1s just fine. Can we rebase this PR and mark it for review so we can get someone from ArchBOM to approve it? With this merged, we no longer need (and can close) the apple-silicone branch. Thank you. |
NIXKnight
force-pushed
the
NIXKnight/PSRE-1800
branch
from
5a18773 to
8da3a26
Compare
Contributor
Author
|
@johnnagro I have re-based the branch. The PR is ready for review. |
Contributor
|
👀 Watching along because I'm interested in whether we could do the same thing in Tutor |
Contributor
|
@johnnagro is the build script for these images internal or is it something I could peek at? |
Contributor
Author
@kdmccormick We are planning to update the configuration repo with a new MySQL Dockerfile and a GitHub Actions workflow that builds the image. |
Contributor
|
Nice, thanks Saad. |
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new MySQL 5.7 images uses Docker Buildx to build container image for multiple platforms. Currently the image is built for amd64 and arm64 CPU architectures.