Skip to content

fix: Review fix of un-imported Content of Common Cartridge to OLX#143

Open
FahadKhalid210 wants to merge 1 commit intoopenedx:masterfrom
edly-io:fahad-fix-imports
Open

fix: Review fix of un-imported Content of Common Cartridge to OLX#143
FahadKhalid210 wants to merge 1 commit intoopenedx:masterfrom
edly-io:fahad-fix-imports

Conversation

@FahadKhalid210
Copy link

Fix un-imported contents

Fixes:

  • Successfully imported the learning-application-resource type when the file suffix is ".html".
  • Fixed html of images that are not in web_resources
  • Added the static files from the resources directory into the static directory.
  • Resolved the errors related to KeyError and AttributeError.

@FahadKhalid210
Copy link
Author

@michaelroytman @alangsto @ilee2u
Kindly review this PR.
Thanks

@FahadKhalid210 FahadKhalid210 changed the title Review fix of un-imported Content of Common Cartridge to OLX Fix: Review fix of un-imported Content of Common Cartridge to OLX Jun 7, 2023
@FahadKhalid210 FahadKhalid210 changed the title Fix: Review fix of un-imported Content of Common Cartridge to OLX fix: Review fix of un-imported Content of Common Cartridge to OLX Jun 7, 2023
@alangsto
Copy link
Contributor

alangsto commented Jun 7, 2023

Hi @FahadKhalid210, our team has been notified and will prioritize reviewing this PR accordingly.

@ziafazal ziafazal requested a review from michaelroytman June 6, 2024 06:09
@ziafazal
Copy link

ziafazal commented Jun 6, 2024

@michaelroytman could you please review this PR?

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test image needs to be updated and the branch needs to be rebased.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a logo of the Scratch Cat, which is as trademarked image so you should add a new image that is safe for us to store here, ideally something that's in the creative commons or license free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants