-
Notifications
You must be signed in to change notification settings - Fork 15
[BD-27] Create transcript nodes in video blocks #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alangsto
merged 13 commits into
openedx:master
from
open-craft:jani/video-xblock-transcripts
Jun 14, 2021
Merged
[BD-27] Create transcript nodes in video blocks #66
alangsto
merged 13 commits into
openedx:master
from
open-craft:jani/video-xblock-transcripts
Jun 14, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add the new column that contains dash separated, alphabetically ordered language codes to the output CSV. This is used by cc2olx to add transcript tags in the generated video block.
|
Thanks for the pull request, @janimo! I've created BLENDED-857 to keep track of it in Jira. More details are on the BD-27 project page. When this pull request is ready, tag your edX technical lead. |
fe324ea to
eef53f5
Compare
926a6ad to
cdd933c
Compare
Contributor
alangsto
approved these changes
Jun 14, 2021
Contributor
alangsto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #61 and deals with the cc2olx part of transcripts.
For each language code found in the input links CSV file it will create a child node in the video block.