Skip to content

Conversation

@janimo
Copy link
Contributor

@janimo janimo commented May 27, 2021

This is rebased on #61 and deals with the cc2olx part of transcripts.
For each language code found in the input links CSV file it will create a child node in the video block.

Jani Monoses added 5 commits May 27, 2021 09:22
This add the new column that contains dash separated, alphabetically
ordered language codes to the output CSV. This is used by cc2olx to
add transcript tags in the generated video block.
@openedx-webhooks
Copy link

openedx-webhooks commented May 27, 2021

Thanks for the pull request, @janimo! I've created BLENDED-857 to keep track of it in Jira. More details are on the BD-27 project page.

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 27, 2021
@janimo janimo changed the title Create transcript nodes in video blocks [BD-27] Create transcript nodes in video blocks May 27, 2021
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels May 27, 2021
@kaizoku kaizoku force-pushed the jani/video-xblock-transcripts branch from fe324ea to eef53f5 Compare June 7, 2021 21:39
@kaizoku kaizoku force-pushed the jani/video-xblock-transcripts branch from 926a6ad to cdd933c Compare June 12, 2021 02:43
@kaizoku
Copy link
Contributor

kaizoku commented Jun 12, 2021

@alangsto , I've rebased this against #61 and it's ready for review.

Copy link
Contributor

@alangsto alangsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alangsto alangsto merged commit f0d8058 into openedx:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants