Skip to content

Conversation

@haftamuk
Copy link
Contributor

@haftamuk haftamuk commented Oct 6, 2025

PR 37331 adds a feature to be able to share to linkedin with an option to consider course level "Organization Name".

Linked Issue: ISSUE

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 6, 2025

Thanks for the pull request, @haftamuk!

This repository is currently maintained by @openedx/wg-maintenance-docs.openedx.org.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 6, 2025
Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still in draft but this looks nice, thanks. feel free to tag me in the review when you are ready to take it out of draft.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 6, 2025
@haftamuk haftamuk marked this pull request as ready for review October 7, 2025 09:41
@haftamuk haftamuk requested a review from deborahgu October 7, 2025 09:43
@Cup0fCoffee
Copy link

@haftamuk please link the PR properly, i.e. openedx/openedx-platform#37331.

@Cup0fCoffee
Copy link

@haftamuk Looks great, thank you for the PR!

Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the main code change is merge, LGTM! thanks for updating docs!

@sarina
Copy link
Contributor

sarina commented Oct 9, 2025

@haftamuk this is a great change and it looks like openedx/openedx-platform#37331 was merged. Could you make the change I suggest then we'll merge?

PR 37331 adds a feature to be able to share to linkedin with an option to  consider course level "Organization Name".
@haftamuk
Copy link
Contributor Author

@haftamuk this is a great change and it looks like openedx/edx-platform#37331 was merged. Could you make the change I suggest then we'll merge?

Kindly see the changes made.
image

Also regarding the config file, I have changed it to lms/envs/common.py from lms.yaml. Let me know if I should revert this change!

@sarina sarina merged commit 1e78c17 into openedx:main Oct 14, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants