-
Notifications
You must be signed in to change notification settings - Fork 78
Documentation updated to reflect changes in PR 37331 #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @haftamuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
252b4c6 to
d5c01b5
Compare
deborahgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still in draft but this looks nice, thanks. feel free to tag me in the review when you are ready to take it out of draft.
d5c01b5 to
ee03af9
Compare
|
@haftamuk please link the PR properly, i.e. openedx/openedx-platform#37331. |
|
@haftamuk Looks great, thank you for the PR! |
deborahgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once the main code change is merge, LGTM! thanks for updating docs!
source/site_ops/install_configure_run_guide/configuration/enable_socialsharing_icons.rst
Outdated
Show resolved
Hide resolved
|
@haftamuk this is a great change and it looks like openedx/openedx-platform#37331 was merged. Could you make the change I suggest then we'll merge? |
PR 37331 adds a feature to be able to share to linkedin with an option to consider course level "Organization Name".
ee03af9 to
ed1d133
Compare
Also regarding the config file, I have changed it to |

PR 37331 adds a feature to be able to share to linkedin with an option to consider course level "Organization Name".
Linked Issue: ISSUE