Fix/forum patches sumac #36606
Merged
Fix/forum patches sumac #36606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local>
Explicitly passed course_id to all views
Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local>
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @Abdul-Muqadim-Arbisoft! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data
feanil/ubuntu 24.04
ziafazal
merged commit c1804f5
into
openedx:open-release/sumac.master
49 of 50 checks passed
zubairshakoorarbisoft
pushed a commit
to zubairshakoorarbisoft/edx-platform
that referenced
this pull request
May 9, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> Co-authored-by: Ali Salman <88362079+Ali-Salman29@users.noreply.github.com> Co-authored-by: Kyle McCormick <kyle@axim.org> Co-authored-by: Feanil Patel <feanil@axim.org>
zubairshakoorarbisoft
pushed a commit
to zubairshakoorarbisoft/edx-platform
that referenced
this pull request
May 9, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> Co-authored-by: Ali Salman <88362079+Ali-Salman29@users.noreply.github.com> Co-authored-by: Kyle McCormick <kyle@axim.org> Co-authored-by: Feanil Patel <feanil@axim.org>
Asespinel
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
May 26, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> Co-authored-by: Ali Salman <88362079+Ali-Salman29@users.noreply.github.com> Co-authored-by: Kyle McCormick <kyle@axim.org> Co-authored-by: Feanil Patel <feanil@axim.org>
Waleed-Mujahid
added a commit
to edly-io/edx-platform
that referenced
this pull request
Jun 13, 2025
* fix: allow_to_create_new_org checks org autocreate [FC-0076] (openedx#36094) (openedx#36288) Updates the StudioHome API's allow_to_create_new_org to require both organization-creation permissions and ORGANIZATION_AUTOCREATE to be enabled. It also adds the list of "allowed organizations for libraries" to the Studio Home API so that the Authoring MFE can use it. (cherry picked from commit b96a3bf) * chore: upgrade Django to 4.2.20 * fix: pasted component search index document missing breadcrumbs [sumac] [FC-0076] * Fix/forum patches sumac (openedx#36606) * fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> Co-authored-by: Ali Salman <88362079+Ali-Salman29@users.noreply.github.com> Co-authored-by: Kyle McCormick <kyle@axim.org> Co-authored-by: Feanil Patel <feanil@axim.org> * Merge commit from fork Allow overriding but prevent download by default. Also, extract `PYTHON_LIB_FILENAME` Django setting as a shared function and document the setting. --------- Co-authored-by: Jillian <jill@opencraft.com> Co-authored-by: magajh <maria.jaimes@edunext.co> Co-authored-by: Rômulo Penido <romulo.penido@gmail.com> Co-authored-by: Feanil Patel <feanil@axim.org> Co-authored-by: Abdul-Muqadim-Arbisoft <139064778+Abdul-Muqadim-Arbisoft@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> Co-authored-by: Ali Salman <88362079+Ali-Salman29@users.noreply.github.com> Co-authored-by: Kyle McCormick <kyle@axim.org> Co-authored-by: Tim McCormack <59623490+timmc-edx@users.noreply.github.com>
Waleed-Mujahid
pushed a commit
to edly-io/edx-platform
that referenced
this pull request
Aug 4, 2025
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> Co-authored-by: Ali Salman <88362079+Ali-Salman29@users.noreply.github.com> Co-authored-by: Kyle McCormick <kyle@axim.org> Co-authored-by: Feanil Patel <feanil@axim.org>
Waleed-Mujahid
added a commit
to edly-io/edx-platform
that referenced
this pull request
Aug 4, 2025
* fix: allow_to_create_new_org checks org autocreate [FC-0076] (openedx#36094) (openedx#36288) Updates the StudioHome API's allow_to_create_new_org to require both organization-creation permissions and ORGANIZATION_AUTOCREATE to be enabled. It also adds the list of "allowed organizations for libraries" to the Studio Home API so that the Authoring MFE can use it. (cherry picked from commit b96a3bf) * chore: upgrade Django to 4.2.20 * fix: pasted component search index document missing breadcrumbs [sumac] [FC-0076] * Fix/forum patches sumac (openedx#36606) * fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> Co-authored-by: Ali Salman <88362079+Ali-Salman29@users.noreply.github.com> Co-authored-by: Kyle McCormick <kyle@axim.org> Co-authored-by: Feanil Patel <feanil@axim.org> * Merge commit from fork Allow overriding but prevent download by default. Also, extract `PYTHON_LIB_FILENAME` Django setting as a shared function and document the setting. --------- Co-authored-by: Jillian <jill@opencraft.com> Co-authored-by: magajh <maria.jaimes@edunext.co> Co-authored-by: Rômulo Penido <romulo.penido@gmail.com> Co-authored-by: Feanil Patel <feanil@axim.org> Co-authored-by: Abdul-Muqadim-Arbisoft <139064778+Abdul-Muqadim-Arbisoft@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01434.local> Co-authored-by: Ali Salman <88362079+Ali-Salman29@users.noreply.github.com> Co-authored-by: Kyle McCormick <kyle@axim.org> Co-authored-by: Tim McCormack <59623490+timmc-edx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks key fixes for the forum and discussion blocks from master into the open-release/sumac.master branch. These changes are required to ensure forum functionality in the Sumac release.