add more semantics to API exceptions related to subsidy fulfillment#207
Open
iloveagent57 wants to merge 1 commit intomainfrom
Open
add more semantics to API exceptions related to subsidy fulfillment#207iloveagent57 wants to merge 1 commit intomainfrom
iloveagent57 wants to merge 1 commit intomainfrom
Conversation
08b78e4 to
9707b2a
Compare
pwnage101
reviewed
Jun 28, 2023
Comment on lines
+114
to
+117
| ``subsidy_error_detail`` is either a string describing an error message, | ||
| a dict with a "message" key describing an error message, or a list of such | ||
| dicts. This helper method widdles any of those things down into a single | ||
| error message string. |
Contributor
There was a problem hiding this comment.
Is this just the result of the subsidy API being indecisive about error formatting and being written by >1 person?
Contributor
There was a problem hiding this comment.
Oof yes, can we fix the offending call?
Contributor
Author
There was a problem hiding this comment.
I wrote it to be defensive about the types of messages that can exist from a DRF APIException: https://github.com/encode/django-rest-framework/blob/master/rest_framework/exceptions.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change helps to thread error responses from GEAG back through the response payloads of enterprise-subsidy and enterprise-access in our redemption flow.
It also sets up a more generic framework for describing, to the caller of the policy redeem endpoint, the semantics of failures that occur in the downstream redeem request of the subsidy API.
The structure of the error response will be like so (should be backwards compatible):