feanil/update pymongo #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmtcril
approved these changes
Jan 9, 2025
Contributor
bmtcril
left a comment
bmtcril
left a comment
There was a problem hiding this comment.
Sorry for the delay on this. I imagine there is some work to be done here to get the requirements handling working the same as everywhere else, but what I'm seeing is that this mirrors the pinning in edx-platform: https://github.com/openedx/edx-platform/blob/03430adeb14afef2a3700f2aa73e3ce5f9758906/requirements/constraints.txt#L172
I think the change is ok based on what I'm seeing, though.
So pinning to a minor version under 4.x is weird. THe only breaking change that is in the changelogs is at 4.7 with a change that doesn't affect this repo. Breaking Change: https://pymongo.readthedocs.io/en/stable/changelog.html#id7 Changelog: https://pymongo.readthedocs.io/en/stable/changelog.html#changelog
feanil
force-pushed
the
feanil/update_pymongo
branch
from
3b43e63 to
173fce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated to 4.x a while ago so I'm not sure why pymongo is pinned this way. The usage in this repo are pretty minimal so I think the testing will catch any issues that crop up.