feat!: update runtime config support #157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: rename `mfeConfigApiUrl` to `runtimeConfigJsonUrl` BREAKING CHANGE: remove `siteId` from config URL building add cache buster for development environments
Comment on lines
-168
to
+169
| const { mfeConfigApiUrl, siteId } = getSiteConfig(); | ||
| const { runtimeConfigJsonUrl, environment } = getSiteConfig(); |
Contributor
Author
There was a problem hiding this comment.
My understanding of the new runtime config architecture is that the build-time site config will just point to a URL, and we won't have a concept of siteId.
Comment on lines
+177
to
+181
| // In development mode, add a timestamp as a cache buster | ||
| // to support live-editing runtime config JSON | ||
| if (environment === EnvironmentTypes.DEVELOPMENT) { | ||
| runtimeConfigUrl.searchParams.set('timestamp', Date.now()); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is super helpful for local dev (live editing the json and seeing things update). I'm not sure if this is a pattern we're happy with, and I'm very open to other ideas about how to handle this use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: rename
mfeConfigApiUrltoruntimeConfigJsonUrlBREAKING CHANGE: remove
siteIdfrom config URL buildingadd cache buster for development environments