feat: [FC-0047] Full-Bleed Header + Top Navigation #278

PavloNetrebchuk · 2024-04-02T11:02:15Z

This PR introduces updated navigation and banner for the course home.

Light theme	Dark theme

Landscape	Tablet
In the horizontal state, the top bar is always collapsed.	The tablet version doesn't have a collapsing effect.

Android < 12
https://github.com/openedx/openedx-app-android/assets/127732735/5cc29cf1-751e-443b-a54f-f129063f6b88

🚨 Breaking changes 🚨:
The COURSE_BANNER_ENABLED and COURSE_TOP_TAB_BAR_ENABLED feature flags have been removed.

…, minor code refactoring

…e flags

openedx-webhooks · 2024-04-02T11:02:19Z

Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

…abClickedEvent

…eader # Conflicts: # course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineScreen.kt

volodymyr-chekyrta · 2024-04-04T14:14:51Z

Ready for product review

marcotuts

Product review only 👍

…eader

discussion/src/main/java/org/openedx/discussion/presentation/topics/DiscussionTopicsFragment.kt

course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineScreen.kt

core/src/main/java/org/openedx/core/ImageProcessor.kt

HamzaIsrar12

Swipe-to-refresh is still not working on the Dates and Discussion tabs.

course/src/main/java/org/openedx/course/presentation/dates/CourseDatesScreen.kt

core/src/main/java/org/openedx/core/ui/ComposeCommon.kt

core/src/main/java/org/openedx/core/ui/TabItem.kt

course/src/main/java/org/openedx/course/presentation/container/CourseHomeTab.kt

course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineScreen.kt

PavloNetrebchuk · 2024-04-25T12:15:11Z

@HamzaIsrar12 You were correct about the pull-to-refresh. The data has been updated, but I forgot to hide the progress bar.😅
I have pushed all the changes. Hopefully, I haven't lost anything this time.

…_header

PavloNetrebchuk · 2024-04-29T10:20:06Z

@k1rill @HamzaIsrar12
Hi there, when do you think you'll be able to check out PRs?

k1rill

Only question about viewModels left from my side, thank you

HamzaIsrar12 · 2024-04-29T15:02:34Z

I'll finish my reviews by the end of the day today. 👍🏻

HamzaIsrar12 · 2024-04-29T18:42:33Z

Hi @PavloNetrebchuk , I see you're addressing Kirill's feedback. Once you're done, could you please re-request the review from the Reviewers section? I'd rather not review something that might change. 😄👍🏻

…eader # Conflicts: # core/src/main/java/org/openedx/core/ui/theme/AppColors.kt # core/src/main/java/org/openedx/core/ui/theme/Theme.kt # core/src/main/res/values/strings.xml # core/src/openedx/org/openedx/core/ui/theme/Colors.kt

HamzaIsrar12

The happy scenarios are working fine ✨ ; it's just that in offline mode, the after-reloading states are a bit buggy. However, since we have a ticket for properly handling the error state, I think we can ignore them for now.

Other than that, I've only requested minor refactoring and formatting in the code, which I believe we won't be able to address later on.

core/src/main/java/org/openedx/core/presentation/course/CourseContainerTab.kt

course/src/main/java/org/openedx/course/presentation/container/CourseContainerFragment.kt

...ussion/src/main/java/org/openedx/discussion/presentation/topics/DiscussionTopicsViewModel.kt

core/src/main/java/org/openedx/core/ImageProcessor.kt

HamzaIsrar12

Looks good to me 🏎️ ✨

e0d · 2024-04-30T13:23:03Z

We discussed in the strat meeting that this should be good to merge, @volodymyr-chekyrta.

volodymyr-chekyrta · 2024-04-30T13:26:52Z

We discussed in the strat meeting that this should be good to merge, @volodymyr-chekyrta.

@e0d Thank you!

I don't have permission to merge it without @k1rill's approval.

Discussed in the team meeting, capacity is a blocker, we have multiple thumbs.

openedx-webhooks · 2024-04-30T15:55:15Z

@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

PavloNetrebchuk added 4 commits March 28, 2024 23:13

feat: New header and navigation on CourseContainerFragment

daeab51

feat: Changed logic of swipe to refresh, added blur for android <= 12…

1b02a48

…, minor code refactoring

feat: removed COURSE_TOP_BAR_ENABLED and COURSE_BANNER_ENABLED featur…

378e876

…e flags

feat: special header style for android < 12

76cda81

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 2, 2024

volodymyr-chekyrta changed the title ~~Feat: Full Bleed Course Image and Header + Visual Pill Appearance~~ feat: [FC-0047] Full Bleed Course Image and Header + Visual Pill Appearance Apr 2, 2024

PavloNetrebchuk force-pushed the feat/course_home_header branch from 335da1f to 42c81d5 Compare April 2, 2024 12:49

volodymyr-chekyrta changed the title ~~feat: [FC-0047] Full Bleed Course Image and Header + Visual Pill Appearance~~ feat: [FC-0047] Full-Bleed Header + Top Navigation Apr 2, 2024

volodymyr-chekyrta added the product review PR requires product review before merging label Apr 2, 2024

fix: Fixed header image blur for android < 12. Added courseContainerT…

9707ac8

…abClickedEvent

PavloNetrebchuk force-pushed the feat/course_home_header branch from 42c81d5 to 9707ac8 Compare April 2, 2024 15:39

PavloNetrebchuk added 5 commits April 2, 2024 18:48

Merge remote-tracking branch 'origin/develop' into feat/course_home_h…

e9fc5af

…eader # Conflicts: # course/src/main/java/org/openedx/course/presentation/outline/CourseOutlineScreen.kt

feat: auto scrolling header to collapsed and expanded states

38709fe

fix: Fixed junit tests

d8d2f57

fix: Fixed CourseContainerViewModelTest

6aadad1

fix: auto scroll fling fix

ada422d

PavloNetrebchuk marked this pull request as ready for review April 4, 2024 14:15

marcotuts self-requested a review April 4, 2024 18:10

marcotuts approved these changes Apr 4, 2024

View reviewed changes

volodymyr-chekyrta self-requested a review April 5, 2024 09:06

PavloNetrebchuk added 2 commits April 8, 2024 14:41

feat: CourseContainerFragment refactoring

a6ab821

Merge remote-tracking branch 'origin/develop' into feat/course_home_h…

ad32e9f

…eader

volodymyr-chekyrta previously approved these changes Apr 8, 2024

View reviewed changes

PavloNetrebchuk dismissed volodymyr-chekyrta’s stale review via 1b5a56c April 10, 2024 14:52

PavloNetrebchuk force-pushed the feat/course_home_header branch 3 times, most recently from 31ced6d to 07e2f11 Compare April 10, 2024 15:14

fix: Removed expanded header content top padding

e079ded

fix: Fixes according to PR feedback

655d2f4

PavloNetrebchuk force-pushed the feat/course_home_header branch from 9890076 to 655d2f4 Compare April 24, 2024 17:03

HamzaIsrar12 reviewed Apr 24, 2024

View reviewed changes

HamzaIsrar12 requested changes Apr 24, 2024

View reviewed changes

fix: Fixes according to PR feedback

64030e4

PavloNetrebchuk force-pushed the feat/course_home_header branch from b4a5157 to 64030e4 Compare April 25, 2024 12:10

Merge remote-tracking branch 'upstream/develop' into feat/course_home…

0e1fd12

…_header

k1rill reviewed Apr 29, 2024

View reviewed changes

refactor: Refactored view models of course container screens

a314e3d

PavloNetrebchuk force-pushed the feat/course_home_header branch from 6cd3747 to a314e3d Compare April 29, 2024 19:41

PavloNetrebchuk requested review from HamzaIsrar12 and k1rill April 29, 2024 19:43

HamzaIsrar12 requested changes Apr 29, 2024

View reviewed changes

HamzaIsrar12 mentioned this pull request Apr 29, 2024

fix: crash when restoring the app after a long period of inactivity #290

Merged

fix: Fixes according to PR feedback

ef48f3b

PavloNetrebchuk requested a review from HamzaIsrar12 April 30, 2024 09:09

HamzaIsrar12 approved these changes Apr 30, 2024

View reviewed changes

volodymyr-chekyrta removed the request for review from k1rill April 30, 2024 15:49

volodymyr-chekyrta approved these changes Apr 30, 2024

View reviewed changes

volodymyr-chekyrta merged commit 29e1c8e into openedx:develop Apr 30, 2024

volodymyr-chekyrta deleted the feat/course_home_header branch April 30, 2024 15:55

feat: [FC-0047] Full-Bleed Header + Top Navigation #278

feat: [FC-0047] Full-Bleed Header + Top Navigation #278

Uh oh!

Conversation

PavloNetrebchuk commented Apr 2, 2024 • edited by volodymyr-chekyrta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openedx-webhooks commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

volodymyr-chekyrta commented Apr 4, 2024

Uh oh!

marcotuts left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HamzaIsrar12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PavloNetrebchuk commented Apr 25, 2024

Uh oh!

PavloNetrebchuk commented Apr 29, 2024

Uh oh!

k1rill left a comment

Choose a reason for hiding this comment

Uh oh!

HamzaIsrar12 commented Apr 29, 2024

Uh oh!

HamzaIsrar12 commented Apr 29, 2024

Uh oh!

HamzaIsrar12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HamzaIsrar12 left a comment

Choose a reason for hiding this comment

Uh oh!

e0d commented Apr 30, 2024

Uh oh!

volodymyr-chekyrta commented Apr 30, 2024

Uh oh!

openedx-webhooks commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

PavloNetrebchuk commented Apr 2, 2024 •

edited by volodymyr-chekyrta

Loading

openedx-webhooks commented Apr 2, 2024 •

edited

Loading