fix: update config parsing structure #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerhabib26
requested review from
HamzaIsrar12,
dixidroid,
farhan-arshad-dev and
k1rill
and removed request for
HamzaIsrar12,
farhan-arshad-dev and
k1rill
HamzaIsrar12
previously approved these changes
May 16, 2024
omerhabib26
force-pushed
the
omer/LEARNER-9891
branch
from
af8b8d5 to
5485df6
Compare
k1rill
previously approved these changes
May 20, 2024
Contributor
Author
|
@volodymyr-chekyrta please spare some time to review this PR. |
Contributor
|
Any chance to merge it after the #308 changes? |
dixidroid
previously approved these changes
May 21, 2024
Contributor
Author
|
@volodymyr-chekyrta sure we can merge it after PR-308 and update the config structure accordingly. |
Contributor
Thank you! |
- Update dictionary for ProgramConfig - Update UI related feature flags under a single Key - fix image load in course fix: LEARNER-9891
omerhabib26
dismissed stale reviews from dixidroid, volodymyr-chekyrta, and k1rill
via
ea10ace
omerhabib26
force-pushed
the
omer/LEARNER-9891
branch
from
5485df6 to
ea10ace
Compare
omerhabib26
force-pushed
the
omer/LEARNER-9891
branch
from
dc13847 to
acd4a03
Compare
HamzaIsrar12
approved these changes
May 30, 2024
volodymyr-chekyrta
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: Issue-318