Skip to content

Conversation

@volodymyr-chekyrta
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta commented May 14, 2024

This PR is related to the FC-0047 course home redesign and includes the new certificate message block.

Design:
https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?node-id=14957-309221&t=e1C9Uxns0YlV3sHh-0

Demo:

Phone Tablet
image image

Changes:

  • Introduced new composable function CourseMessage.
  • Removed unused CourseImageHeader and string resources.

Checklist:
✅ Certificate message appears if the course certificate is earned
✅ A11y. The message block has a big clickable area and works as 1 object for the TalkBack

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 14, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@volodymyr-chekyrta volodymyr-chekyrta force-pushed the feature/course_home_certificate branch from 4ccad97 to aa3175d Compare May 14, 2024 20:03
@volodymyr-chekyrta volodymyr-chekyrta changed the base branch from main to develop May 14, 2024 20:05
@volodymyr-chekyrta volodymyr-chekyrta added the product review PR requires product review before merging label May 14, 2024
@volodymyr-chekyrta volodymyr-chekyrta force-pushed the feature/course_home_certificate branch 2 times, most recently from 5c52a0b to 31ae726 Compare May 15, 2024 17:27
@volodymyr-chekyrta
Copy link
Contributor Author

@HamzaIsrar12 @k1rill, Kindly review the changes made in this pull request. Thank you.

@volodymyr-chekyrta volodymyr-chekyrta removed the product review PR requires product review before merging label May 15, 2024
@omerhabib26 omerhabib26 requested review from omerhabib26 and removed request for omerhabib26 May 17, 2024 07:05
HamzaIsrar12
HamzaIsrar12 previously approved these changes May 20, 2024
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit only. 👍🏻

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️

@volodymyr-chekyrta volodymyr-chekyrta merged commit f7d4d5f into openedx:develop May 20, 2024
@openedx-webhooks
Copy link

@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/course_home_certificate branch May 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants