Skip to content

Conversation

@volodymyr-chekyrta
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta commented Jun 7, 2024

This PR introduces a fallback for the sourceSets directory.
This fallback is aimed at fixing an issue with the Tutor build.

Config:

THEME_DIRECTORY: "openedx"

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 7, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@HamzaIsrar12
Copy link
Contributor

@volodymyr-chekyrta A better solution would be to introduce a new flag with the default value openedx and base the resources on that, instead of relying on the platformName. Thoughts?

@volodymyr-chekyrta volodymyr-chekyrta force-pushed the fix/platform_name_fallback branch from a5da067 to 93818c0 Compare June 7, 2024 19:42
@volodymyr-chekyrta
Copy link
Contributor Author

@volodymyr-chekyrta A better solution would be to introduce a new flag with the default value openedx and base the resources on that, instead of relying on the platformName. Thoughts?

@HamzaIsrar12, I was thinking about this option too.
I've updated the approach to the feature flag ✅

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer THEME_DIRECTORY because it covers fonts, drawables, views etc

@volodymyr-chekyrta volodymyr-chekyrta force-pushed the fix/platform_name_fallback branch from 93818c0 to ea0132e Compare June 7, 2024 20:07
@volodymyr-chekyrta volodymyr-chekyrta force-pushed the fix/platform_name_fallback branch from ea0132e to 3980a15 Compare June 7, 2024 20:07
@volodymyr-chekyrta
Copy link
Contributor Author

I would prefer THEME_DIRECTORY because it covers fonts, drawables, views etc

Makes sense 👍
Updated ✅

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this much-needed PR! 😄

@volodymyr-chekyrta volodymyr-chekyrta merged commit 21bd1a1 into openedx:develop Jun 8, 2024
@openedx-webhooks
Copy link

@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the fix/platform_name_fallback branch June 8, 2024 08:15
cmltaWt0 pushed a commit to raccoongang/openedx-app-android that referenced this pull request Jun 10, 2024
volodymyr-chekyrta added a commit that referenced this pull request Jun 10, 2024
volodymyr-chekyrta added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants