-
Notifications
You must be signed in to change notification settings - Fork 48
feat: [FC-0047] FCM #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0047] FCM #344
Conversation
|
Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
759c2c0 to
cfe75f2
Compare
|
@dixidroid @omerhabib26, Kindly review the changes made in this pull request. |
efc1c87 to
7381828
Compare
|
LGTM |
7381828 to
1577d97
Compare
|
Reviewing ... |
HamzaIsrar12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits only. 👍🏻
app/src/main/java/org/openedx/app/system/push/OpenEdXFirebaseMessagingService.kt
Outdated
Show resolved
Hide resolved
|
@HamzaIsrar12, thanks for your feedback, PR is ready for the next pass 🚀 |
HamzaIsrar12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏎️
|
@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This pull request introduces Firebase Cloud Messaging (FCM) to the project, enabling the functionality for receiving push notifications from Firebase.
Testing:
• Verified push notifications are received when the app is in the foreground, background, and terminated states.
• Confirmed the app correctly handles notification taps and displays relevant content.
• Ensured token generation and handling work as expected, including handling token refreshes.
Please use the Firebase console for testing; here is a set of all the required fields for navigation:
Notifications:
notification_type:
enrollcourse_id: Your course ID (example: course-v1:future+f1+2024)
notification_type:
unenrollnotification_type:
add_beta_testercourse_id: Your course ID (example: course-v1:future+f1+2024)
notification_type:
remove_beta_testercourse_id: Your course ID (example: course-v1:future+f1+2024)
notification_type:
forum_responsetopic_id: Your Topic ID (example: course)
course_id: Your course ID (example: course-v1:future+f1+2024)
thread_id: Your thread ID (example: 66584e96f2195c001ad219c7)
comment_id: Your comment ID (example: 66585c9df2195c001ad219ce)
notification_type:
forum_commenttopic_id: Your Topic ID (example: course)
course_id: Your course ID (example: course-v1:future+f1+2024)
thread_id: Your thread ID (example: 66583d13f2195c001a56a182)
parent_id: Your response ID (example: 66586579f2195c001ad219d8)
comment_id: Your comment ID (example: 6659ac92f2195c001bf37f77)