fix: Video Subtitles on Native and Youtube Player #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-chekyrta
previously approved these changes
Jun 25, 2024
dixidroid
previously approved these changes
Jul 1, 2024
Contributor
|
No need for this PR, everything is already handled in #347 |
Contributor
Author
|
@omerhabib26 The commit from this branch was mistakenly cherry-picked there, so I removed it. |
Contributor
|
@HamzaIsrar12 just a minor suggestion, Can you update the highlighted text style to SemiBold for better visibility? |
omerhabib26
previously approved these changes
Jul 3, 2024
HamzaIsrar12
dismissed stale reviews from omerhabib26, dixidroid, and volodymyr-chekyrta
via
fb68cff
volodymyr-chekyrta
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The video subtitles weren't working because the handler was deleted.