Skip to content

fix: bug when unable to see new loaded items on the All Courses screen #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volodymyr-chekyrta merged 2 commits into from
Oct 7, 2024
Merged

fix: bug when unable to see new loaded items on the All Courses screen #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75ac68d
Merge pull request #1 from openedx/develop
dixidroid Oct 4, 2024
7ef896f
fix: bug when unable to see new loaded items on the All Courses screen
dixidroid Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dashboard/src/main/java/org/openedx/courses/presentation/AllEnrolledCoursesView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.layout.widthIn
import androidx.compose.foundation.lazy.grid.GridCells
import androidx.compose.foundation.lazy.grid.GridItemSpan
import androidx.compose.foundation.lazy.grid.LazyVerticalGrid
import androidx.compose.foundation.lazy.grid.items
import androidx.compose.foundation.lazy.grid.rememberLazyGridState
Expand Down Expand Up @@ -329,7 +330,7 @@ private fun AllEnrolledCoursesView(
}
)
}
item {
item(span = { GridItemSpan(columns) }) {
if (state.canLoadMore) {
Box(
modifier = Modifier
Expand Down
4 changes: 2 additions & 2 deletions dashboard/src/main/java/org/openedx/courses/presentation/AllEnrolledCoursesViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class AllEnrolledCoursesViewModel(
}
coursesList.clear()
coursesList.addAll(response.courses)
_uiState.update { it.copy(courses = coursesList) }
_uiState.update { it.copy(courses = coursesList.toList()) }
} catch (e: Exception) {
if (e.isInternetError()) {
_uiMessage.emit(UIMessage.SnackBarMessage(resourceManager.getString(R.string.core_error_no_connection)))
Expand Down Expand Up @@ -125,7 +125,7 @@ class AllEnrolledCoursesViewModel(
page = -1
coursesList.addAll(cachedList)
}
_uiState.update { it.copy(courses = coursesList) }
_uiState.update { it.copy(courses = coursesList.toList()) }
} catch (e: Exception) {
if (e.isInternetError()) {
_uiMessage.emit(UIMessage.SnackBarMessage(resourceManager.getString(R.string.core_error_no_connection)))
Expand Down