Skip to content

chore: remove unnecessary type checking #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ian2012 merged 1 commit into from
Nov 13, 2024
Merged

chore: remove unnecessary type checking #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions openedx_learning/apps/authoring/contents/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,7 @@ class Content(models.Model):
# only in file form. It is an error for ``text`` to be None and ``has_file``
# to be False, since that would mean we haven't stored data anywhere at all.
#
# We annotate this because mypy doesn't recognize that ``text`` should be
# nullable when using MultiCollationTextField, but does the right thing for
# TextField. For more info, see:
# https://github.com/openedx/openedx-learning/issues/152
text: models.TextField[str | None, str | None] = MultiCollationTextField(
text = MultiCollationTextField(
blank=True,
null=True,
max_length=MAX_TEXT_LENGTH,
Expand Down