skip LTIConfig test when third_party_auth is not installed #10226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note, we will expect this to have quality failures, as we will expect @mushtaqak 's PR (https://github.com/edx/edx-platform/pull/10222) to have this python failure :) |
Contributor
|
👍 |
Contributor
|
@adampalay @bderusha this approach sounds good to me. |
Contributor
Author
|
Great! once this passes python tests, I'm going to merge |
adampalay
added a commit
that referenced
this pull request
Oct 16, 2015
…-not-installed skip LTIConfig test when third_party_auth is not installed
adampalay
deleted the
adam/skip-test-if-third-party-auth-not-installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bderusha
@benpatterson , what do you think of skipping the tests in this way? The reason I want to do it this way is so that, when we enable
third_party_authin CMS, this test will fail, and we'll have to unskip it.