Badges V2 Feature Branch

[Kelketek]

Description: This PR is the next iteration of the Badging feature in the LMS
Discussions/Specs: https://docs.google.com/document/d/1ob-leRHV97agPGw5ys9uASXrcsU8qf51bzYlKH3mBEM/edit?usp=sharing
Jira Ticket: https://openedx.atlassian.net/browse/SOL-1325
Partner Information: 3rd party-hosted open edX instance, for an edX solutions client.
Sandbox: LMS at http://pr10556.sandbox.opencraft.com CMS at http://studio.pr10556.sandbox.opencraft.com

Components:

• Core infrastructure refactor
• Badging XBlock Service
• Initial Event Awards
• UI (Badge Listing)
• Update Issuing Component
• UI (Sharing modal)

---

Settings

# Use configuration branch that enables swap on the instance to avoid ooming.
edx_ansible_source_repo: 'https://github.com/open-craft/configuration.git'
configuration_version: 'rebased-optional-swap-role'

[openedx-webhooks]

Thanks for the pull request, @Kelketek! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?repo=edx%2Fedx-platform&number=10556

[stroilova]

FYI @mulby on this PR for new Badge analytics events.

Specific link: https://github.com/edx/edx-platform/pull/10556/files#diff-7fa57903a46fbede7993bc2593ba3c0eR121

Wiki page: https://openedx.atlassian.net/wiki/display/AN/Digital+Badging+Event+Design+Modifications

[Kelketek]

@antoviaque @bradenmacdonald @e-kolpakov @smagoun The last PR looks like it will merge soon. Am I clear to merge this feature branch if it does, or does anything else need to be done?

[catong]

@Kelketek image_url appears twice

[Kelketek]

@catong The first image_url is the URL to the badge class's source image. The second one is the baked badge assertion image generated by Badgr, with all the metadata concerning the user's award.

[Kelketek]

@antoviaque @bradenmacdonald @smagoun @pbaruah

This is ready to merge, assuming the tests pass.

[omarkhan]

@Kelketek I get an error when I run this:

*** ValueError: unconverted data remains: .979502Z

It works if I truncate the date string:

badge.data['created_at'][:19]

Also, this is a shorter way of writing this:

assertion.created = datetime.strptime(badge.data['created_at'][:19], "%Y-%m-%dT%H:%M:%S")

[Kelketek]

jenkins run bokchoy

[Kelketek]

@omarkhan I've been instructed to ignore the coveralls test for now-- could you take a look over the latest changes? If they're good I'll put them up on the sandbox.

[Kelketek]

Actually, went ahead and updated it now.

[andy-armstrong]

👍 Great stuff, @Kelketek. Don't forget to squash and fix the quality failure, then merge away!

[Kelketek]

@catong I will be cleaning this up, squashing, and merging tomorrow morning. So you'll want to get the docs in order :)

[mattdrayer]

@Kelketek these most recent two commits LGTM -- 👍

[Kelketek]

@nedbat Disregard previous statement about email-- a recent tweak to the migration should remove the need for any special action.

[bradenmacdonald]

@catong In the end this merged after the release cut, so we are targeting next week's release for docs etc.

[catong]

@bradenmacdonald Sounds good. Thanks!

[bradenmacdonald]

@edx/devops Heads up that if you're cutting a release tomorrow it will include this PR for new badging features, which has migrations.

Much of the new functionality is behind a feature flag though, and won't be enabled on edx.org.

[feanil]

@mattdrayer @Kelketek @bradenmacdonald this change had a migration that deleted a column. This is not backwards compatible with the running software and resulted in errors during the deploy today. The model change and the migration need to be in separate deploys to not break users in production.

[bradenmacdonald]

@feanil Sorry about that. As you can see above I did ping devops about the migration, although I was not aware of the potential issues around deleting columns in particular. Have you made a fix for this or is further action required?

[feanil]

At this point I think we can push it through, but I mostly wanted to leave a note to say do not do this on a table that is more highly trafficked in the future.