userstanding is now OneToOneField #11168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I was able to reproduce, seems like it. Why was this ForeignKey before? OneToOne seems better. Nice catch! |
Contributor
|
I am really sorry just wrongly clicked 'Close and comment' instead of 'Comment' which will now cost rerunning all the tests again. |
Contributor
|
jenkins run python |
Contributor
|
jenkins run bokchoy |
Contributor
Author
|
@Qubad786 probably because the original author had no idea what they were doing |
Contributor
Author
|
@Qubad786 , thumbs up? |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
adampalay
added a commit
that referenced
this pull request
Jan 8, 2016
userstanding is now OneToOneField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@symbolist , sometime in the django upgrade, UserStanding was changed from a ForeignKey to a one to one field. Unfortunately there was no test that checked if the main page even ever loaded :)
@Qubad786 , may you please take a quick look?
Steps to reproduce the error:
expected behavior: no 500 error
actual behavior: 500 error