Course Overview migrations fix: Readd the Facebook URL field #11673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
nasthagiri
added a commit
that referenced
this pull request
Feb 26, 2016
Course Overview migrations fix: Readd the Facebook URL field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR undoes the migration for removing the
facebook_urlcolumn from theCourseOverviewtable, introduced in https://github.com/edx/edx-platform/pull/11326.We need a 2-phase removal of this column in order to support rolling out to multiple workers on prod. Plan:
facebook_urlfield from the django models, but do not remove the column from the underlying table.facebook_urlfrom the underlying table. By this 2nd release, old and new workers will not expect the column to be present.Reviewers: @jcdyer @BenjiLee
FYI: @feanil @jibsheet