No need to invoke classmethods through self.__class__#1198
Merged
Conversation
Contributor
|
Wouldn't it depend if the class method itself is assuming the class for the first arg? |
Contributor
Author
|
classmethods get the class as the first arg even if called on self: |
Contributor
|
I never knew that :-) |
nedbat
added a commit
that referenced
this pull request
Oct 3, 2013
No need to invoke classmethods through self.__class__
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Sep 16, 2016
…anslations-for-multilingual-support Fix translation for cert name in dashboard openedx#1185
Agrendalath
added a commit
to open-craft/openedx-platform
that referenced
this pull request
Oct 19, 2018
* [MCKIN-8418] WIP: Optimize UsersSocialMetrics.get API * [MCKIN-8418] Support flagging threads and comments * Bump versions.
iloveagent57
pushed a commit
that referenced
this pull request
Feb 26, 2024
…1198) `make dev.dbcopyall8` doesn't work unless the mysql containers have been started and are ready to run. This is not the only place we need to wait for a functional check on a container, so in this commit I've gone ahead and started a utility for doing so. This first pass only supports MySQL, but we should at least add Mongo as well, as that's also needed in one of the provisioning scripts. I've moved the _db_copy8_targets from being an order-only prerequisite to being a recursive make call. I'm not sure why the order-only syntax was in use here, but in any case I needed to add in a script call before those targets were called, so it's likely moot. Also: - Drop unneeded `bash -c` wrappers from db copy docker exec calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jtauber you agree, right?