Skip to content

Conversation

@chrisrossi
Copy link
Contributor

Implements the individual due date extension feature. Must be enabled by setting in the environment:

MITX_FEATURES['INDIVIDUAL_DUE_DATES'] = True

screenshot from 2013-10-14 11 36 14

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the course XML is bad, get_units_with_due_date_options may run into an exception while walking the course tree.

Can you call this function only when idash_mode is Extensions?

@chrisrossi
Copy link
Contributor Author

@ichuang, I did a grep for 'idash' in the edX source code and nothing came up--I'm not really sure what you mean by idash_mode. Can you help me understand what you're asking for? Thanks!

@ichuang
Copy link
Contributor

ichuang commented Oct 15, 2013

Glad you found the idash_mode.

We've tested this feature and it's looking good; will have some more comments probably later today, largely on the UI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we have to use UTC, but we'll get (more) grumbling from users. Can we add a reminder of the offset, e.g. "... in UTC (add five hours for EST):"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if I just add a pull down for timezone that defaults to UTC? On submission all dates get converted to UTC, but professors can express time in a local, to them, timezone.

One issue with just putting the message you describe is during daylight savings time (for another two weeks) the offset from UTC is actually 4 hours for the east coast, then it will go back to 5. That just starts getting clunky to explain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point about daylight savings - that's probably one of the reasons for edX going with UTC.

I'd rather not develop new ui widgets for this, tempting though it may be. We can live with the instructor complaints until we can have proper local timezones.

  • Peter

On Oct 17, 2013, at 9:05 AM, Chris Rossi wrote:

In lms/templates/courseware/instructor_dashboard.html:

  • ${_("Individual due date extensions")}

  •  ${_("Specify the {platform_name} email address or username of a student here:").format(platform_name=settings.PLATFORM_NAME)}
    
  •  <input type="text" name="unique_student_identifier">
    
  •  ${_("Choose the graded unit:")}
    
  •  <select name="url">
    
  •    %for title, url in units_with_due_dates:
    
  •    <option value="${url}">${title}</option>
    
  •    %endfor
    
  •  </select>
    
  •  ${_("Specify the individual due date and time in UTC:")}
    
    What if I just add a pull down for timezone that defaults to UTC? On submission all dates get converted to UTC, but professors can express time in a local, to them, timezone.

One issue with just putting the message you describe is during daylight savings time (for another two weeks) the offset from UTC is actually 4 hours for the east coast, then it will go back to 5. That just starts getting clunky to explain.


Reply to this email directly or view it on GitHub.

@singingwolfboy
Copy link
Contributor

@chrisrossi Have you sent in an individual contributor agreement? We'll need one before we can merge this code into master, as documented in the CONTRIBUTING file in the repository.

@pdpinch
Copy link
Contributor

pdpinch commented Oct 23, 2013

David - this work is being paid for by MIT and falls under the edX-MIT agreement.

  • Peter

Peter Pinch | Production Manager, Office of Digital Learning
Massachusetts Institute of Technology
One Broadway, 8th Floor | Cambridge MA 02142
E pdpinch@mit.edu | T 617-253-6256 | C 617-652-0183

On Oct 23, 2013, at 12:45 PM, David Baumgold wrote:

@chrisrossi Have you sent in an individual contributor agreement? We'll need one before we can merge this code into master, as documented in the CONTRIBUTING file in the repository.


Reply to this email directly or view it on GitHub.

@chrisrossi
Copy link
Contributor Author

@singingwolfboy No, what @pdpinch said. Also, this particular merge request is for MIT and their branch. It shouldn't be merged with mainstream edX. I am working on a port of this feature to mainstream edX and will be issuing a pull request for that soon. Thanks!

@singingwolfboy
Copy link
Contributor

@pdpinch @chrisrossi Ah, OK. Never mind!

@sarina sarina mentioned this pull request Nov 15, 2013
ichuang added a commit that referenced this pull request Nov 15, 2013
Feature -- Individual Due Date Extension
@ichuang ichuang merged commit 842a933 into openedx:branch/mitx/frozen-11aug13 Nov 15, 2013
Agrendalath pushed a commit to open-craft/openedx-platform that referenced this pull request Jan 2, 2019
…dndv2

MCKIN-9180 Version bump Drag and Drop V2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants