Fix broken tests for video player

[polesye]

This PR provide fix for disabled video tests.
After enabling some of the JavaScript unit tests works well.
Some tests are fixed.
One test is rewritten to acceptance test.

@wedaly @valera-rozuvan @jzoldak please review.

[singingwolfboy]

Why are you added commented-out tests?

[polesye]

It was commented out before @valera-rozuvan did a fix for Video player. It will be enabled before merge.

[valera-rozuvan]

@polesye Locally, on my machine, all Jasmine tests pass. I tried both test:js:run[xmodule] and test:js:dev[xmodule]. However, one acceptance test is falling: https://gist.github.com/valera-rozuvan/ddb095700e3e81140dac . I believe that you already have mentioned a fix for this https://github.com/edx/edx-platform/blob/86275272690d2cf1f9932217963297cf52c9b1fe/cms/djangoapps/contentstore/features/component_settings_editor_helpers.py#L39 . This fix will come in to master with the PR https://github.com/edx/edx-platform/pull/1344 .

So from me 👍 Good to merge.

[jzoldak]

Looks good to me, though you might want to first rebase to get my refactoring of cms acceptance tests in PR #1370 . That PR will also speed up the video .feature tests because the course/section/subsection are now created programmatically.

👍

[polesye]

Rebased.

[wedaly]

I'm getting some failures locally with the caption acceptance tests. In particular, the "Make sure captions are open" step fails intermittently with a WebDriverException:

"unknown error: Element is not clickable at point (314, 639). Other element would receive the click"

Make sure you're using the ui helper functions in common/djangoapps/terrain/ui_helpers. In particular, the css_click method has retry logic for exactly this kind of exception.

[jzoldak]

@polesye you might want to also get the small change I made today for better synchronization when adding units with the create_component_instance method. It's in PR #1394

[polesye]

@wedaly Some fixes are provided by PR #1394. This branch is rebased. Please check again.

[wedaly]

Ran the acceptance tests a bunch of times and they seem solid. Thanks for taking care of this!

👍