-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Bulk Email improvements for release #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sarina @flowerhack Please review. |
|
Can you explain how this differs from the original prs? Also what PRs does this cover? |
|
@flowerhack It would be particularly helpful if you could try running this branch and just doing a sanity check that the new dash works as you expect. |
|
Just finished looking over the dashboard stuff & ran it locally; everything seems to work as expected, so this looks a-OK from where I'm standing |
|
OK makes sense to me |
set max enrollment for downloads to 200
Responses to Adam's comments; reset common.py, i18n compliance, deleted extraneous email.html file, fixed an HttpResponse, deleted unnecessary commented-out code, some small style tweaks
…n bulk_email subtasks.
…ts that needed it.
Bulk Email improvements for release
This PR contains:
Contains the following PRs:
It does not contain a merge of PR 1260, but the code for that had already been merged into 1209.
The migration of 1322 and 1209 went smoothly. However, PR 1215 required some changes:
These were addressed in the first commit after the @flowerhack commits.