Skip to content

Conversation

@brianhw
Copy link
Contributor

@brianhw brianhw commented Oct 16, 2013

This PR contains:

  • Bulk email authoring, sending, and monitoring on the legacy instructor dash.
  • Bulk email authoring and sending on the beta instructor dash.
  • Enablement of bulk email authoring and sending for specific courses using admin console.

Contains the following PRs:

It does not contain a merge of PR 1260, but the code for that had already been merged into 1209.

The migration of 1322 and 1209 went smoothly. However, PR 1215 required some changes:

  • The branch contained only partial support for disabling buttons for large courses. This code was broken, and was removed during the merge.
  • Changes to scss files needed to support new styling on the instructor dash needed to be manually tweaked.
  • Changes to how the HTML Editor is called as an XModule needed to be reverted to bring into line with older XModule code.

These were addressed in the first commit after the @flowerhack commits.

@brianhw
Copy link
Contributor Author

brianhw commented Oct 16, 2013

@sarina @flowerhack Please review.

@sarina
Copy link
Contributor

sarina commented Oct 16, 2013

Can you explain how this differs from the original prs?

Also what PRs does this cover?

@brianhw
Copy link
Contributor Author

brianhw commented Oct 16, 2013

@flowerhack It would be particularly helpful if you could try running this branch and just doing a sanity check that the new dash works as you expect.

@flowerhack
Copy link
Contributor

Just finished looking over the dashboard stuff & ran it locally; everything seems to work as expected, so this looks a-OK from where I'm standing

@sarina
Copy link
Contributor

sarina commented Oct 16, 2013

OK makes sense to me

Julia Hansbrough and others added 25 commits October 16, 2013 13:01
Responses to Adam's comments; reset common.py, i18n compliance, deleted extraneous email.html file, fixed an HttpResponse, deleted unnecessary commented-out code, some small style tweaks
brianhw added a commit that referenced this pull request Oct 16, 2013
Bulk Email improvements for release
@brianhw brianhw merged commit 97e01be into rc/2013-10-17 Oct 16, 2013
@brianhw brianhw deleted the brian/bulk-email-rc branch October 16, 2013 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants