Bug fix STUD-771: updated grading help text... #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat it should be an integer without the percent sign
|
Can you wrap the user-visible text with gettext() also? For an example, see /edx-platform/cms/templates/js/edit-textbook.underscore. |
|
Can I be even greedier? I just noticed that there is no space between + and "New Assignment Type" at the bottom of the grading page. |
…on the 'New Assignment' button
Contributor
Author
|
Well, okay. I noticed that missing space and decided I wouldn't risk touching another file. But it makes me happy to fix it. Labels and tip text in that file should also be i18n now. |
|
👍 |
Contributor
|
👍 |
frrrances
pushed a commit
that referenced
this pull request
Oct 17, 2013
Bug fix STUD-771: updated grading help text...
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Nov 14, 2016
giovannicimolin
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Feb 9, 2019
MCKIN-9463: bump xblock-ooyala version to v2.0.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the help text on the Weight of the Total Grade to be more clear that it should be an integer without the percent sign. Fixes bug STUD-771. @cahrens and @talbs can you review?