Check that a subtask has not already completed before running. #1388
Conversation
There was a problem hiding this comment.
What if the task is in progress, not completed?
There was a problem hiding this comment.
That's a problem. This PR doesn't address that. I would need to put in memcache-based locking to address that, and that's more invasive than I'm willing to do right now.
There was a problem hiding this comment.
That makes sense - however I am a bit concerned that this still won't address the problems we're seeing
There was a problem hiding this comment.
It is part of the address. It deals with the situation where there is no overlap. The memcache-based locking does not address that condition. I don't have time right now to get that into this release. Hopefully going forward turning off the heartbeat as Carlos suggests will also help, but when we saw this the other day, the tasks were not overlapping.
|
👍 |
Check that a subtask has not already completed before running.
|
You guys are too fast for me 😦 |
|
omg carlos your 😦 is just too cute!!! I will award you a 🐤 and a 🐧 |
@sarina @rocha Fix for today's release.