-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Bumps problem-builder to v2.6.2 #13953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @pomegranited! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request. To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?repo=edx%2Fedx-platform&number=13953 |
itsjeyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pomegranited Looking great. There's a couple comments left to address on open-craft/problem-builder#129; this PR will be good to go once you've done that 👍
- I tested this: Course trees are the same on the different sandboxes. Also SSH'ed into the sandbox for this PR and verified that the correct version of problem-builder got installed (2.6.2).
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A
|
Thanks for the pull request, @pomegranited! I've created OSPR-1573 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
b06d97c to
d2fa2a6
Compare
|
jenkins run a11y |
|
@pomegranited Can you please add the environments and the expected deployment date to the PR description? This will help with our internal workflow. Thank you. |
|
Hi @gsong , looks like we've got a problem-builder bugfix in this week's sprint, so this PR probably won't be necessary. I'll close this and reference the new PR when one is ready. For my reference, what do you mean by "environments"? |
|
@pomegranited Environments = edx.org or edge.edx.org |
|
@gsong Ah gotcha! I know Problem Builder is deployed on edx.org, but I don't know whether it's on edge or not.. And I don't have course creation permissions on studio.edge.edx.org. @bradenmacdonald Do you know? |
|
@pomegranited Problem Builder is enabled on Edge, yes. However, from a quick look, it appears that |
|
@bradenmacdonald Sure thing, I've submitted DEVOPS-5075 requesting the xblock-configuration change be run on edge.edx.org as well. |
|
https://github.com/edx/edx-platform/pull/14013 removes the need for this PR to be merged and deployed, so I'm closing this PR. |
|
@gsong Sorry, I only answered half of your question above. For the desired Merge Deadline, we don't usually provide one unless there is a critical deadline to request. Would you rather we always specified something in our PRs, even if it just says "Merge Deadline: none" ? I'm updating our PR template now, and can make sure this change is included. |
|
@pomegranited I think that would be valuable information to help the teams prioritize. So if something isn't urgent, you can definitely put None, or conversely "ASAP because this is a critical bug fix!". 🙂 |
|
@gsong Lovely, I'll update our docs to reflect this. Thanks for your insight! |
Updates problem-builder to v2.6.2 to address performance concerns raised by problem-builder #119.
cf. open-craft/problem-builder#129
Sandbox URL:
Partner information: DavidsonX
Testing Instructions:
To test this change, compare the v2.6.2 sandbox from this PR with the v2.6.1 sandbox from https://github.com/edx/edx-platform/pull/13938.
Features > Instructor Tools.Reviewers
CC @ormsbee
Settings