Skip to content

Conversation

@jarv
Copy link
Contributor

@jarv jarv commented Oct 23, 2013

No description provided.

@jarv
Copy link
Contributor Author

jarv commented Oct 23, 2013

@feanil @singingwolfboy review?

This fixes https://github.com/edx/edx-platform/pull/1433 which introduced a bug where static files were collected in /opt/wwc/staticfiles/<git hash>/<git hash>

@feanil
Copy link
Contributor

feanil commented Oct 23, 2013

looks good to me.

@singingwolfboy
Copy link
Contributor

So if STATIC_ROOT_BASE is falsy, STATIC_ROOT will not get defined in this file? Is that intentional?

@jarv
Copy link
Contributor Author

jarv commented Oct 23, 2013

Right, since git.revision is not known to the configuration we cannot override STATIC_ROOT in the json file, if STATIC_ROOT_BASE is not in the json it will remain the default set in common.py

@singingwolfboy
Copy link
Contributor

Alright, as long as that's intentional and not an oversight. 👍

jarv added a commit that referenced this pull request Oct 23, 2013
@jarv jarv merged commit cda168d into master Oct 23, 2013
@jzoldak jzoldak deleted the jarv/fix-static-root branch May 5, 2014 14:58
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Dec 21, 2016
(cherry picked from commit 3fce90f712bb73b5558a21a4929f3342463df7da)
xirdneh pushed a commit to open-craft/openedx-platform that referenced this pull request Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants