-
Notifications
You must be signed in to change notification settings - Fork 4.2k
a11y imporvements to wiki/history.html #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotate table cells.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follows W3 table a11y syntax so, this lgtm...
|
@caesar2164 here is one for you too.. and @adampalay another one for you. :) |
lms/templates/wiki/history.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want to remove your dev console statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do when I rebase.
|
Hi @symbolist this PR looks like a very good start. Before I ok it to merge, I'd like to see feedback from someone that better understands the JSON accordion loading (@adampalay ?) just to make sure that works as expected, but accessibility wise this seems to make a lot of sense... |
|
@symbolist just a note - please put the JIRA ticket ID in your commit message going forward (ie This helps us compile our release notes. |
|
Removed console.log() call, rebased, added ticket ID to commit message and tested on IE10+Jaws and ChromeVox. |
|
👍 |
|
LGTM 👍 |
a11y imporvements to wiki/history.html
https://edx-wiki.atlassian.net/browse/LMS-1309