Improve accessibility of forum follow buttons #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They now include screen reader-friendly text, have the ARIA checkbox role, activate on keypress (for space or enter), and occur in the DOM after the header information (title, etc.)
Contributor
There was a problem hiding this comment.
do you need to call event.preventDefault()? (like for spacebar not to scroll down the page)
Author
There was a problem hiding this comment.
toggleFollowing calls preventDefault
Contributor
|
👍 |
1 similar comment
|
👍 |
gwprice
pushed a commit
that referenced
this pull request
Nov 1, 2013
Improve accessibility of forum follow buttons
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They now include screen reader-friendly text, have the ARIA checkbox
role, activate on keypress (for space or enter), and occur in the DOM
after the header information (title, etc.)
@jimabramson @marcotuts @adampalay