Skip to content

Conversation

@cpennington
Copy link
Contributor

No description provided.

@cpennington
Copy link
Contributor Author

@nedbat @sarina: Review?

@nedbat
Copy link
Contributor

nedbat commented Oct 31, 2013

👍

@sarina
Copy link
Contributor

sarina commented Oct 31, 2013

👍

You may want to let @wedaly know about this change

@sarina
Copy link
Contributor

sarina commented Nov 8, 2013

There really aren't many errors in your code so I don't know why this isn't passing. Maybe try rebasing and rebuilding? The only few pylint errors you have I think you could fix are

lms/lib/xblock/field_data.py (97.1%):
    19: E0012: (bad-option-value): Bad option value 'protected-member'
    19: W0212: (protected-access), LmsFieldData.__init__: Access to a protected member _authored_data of a client class
lms/djangoapps/django_comment_client/middleware.py (0.0%):
    1: C0111: (missing-docstring): Missing docstring

@cpennington
Copy link
Contributor Author

Merged as part of #1531

@cpennington cpennington deleted the lms-libs-off-sys-path branch November 18, 2013 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants