Skip to content

Conversation

@ny0m
Copy link
Contributor

@ny0m ny0m commented Aug 8, 2017

Quick PR to update edx-private requirements to include the latest version of problem-builder.

Dependencies: None

Merge deadline: None

Testing instructions:

From repo root:

  1. pip install -r requirements/edx/edx-private.txt
  2. See no errors

Reviewers

@openedx-webhooks
Copy link

Thanks for the pull request, @bradmerlin! I've created OSPR-1854 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Aug 8, 2017
@ny0m ny0m closed this Aug 8, 2017
@ny0m ny0m reopened this Aug 8, 2017
@ny0m ny0m closed this Aug 8, 2017
@ny0m ny0m reopened this Aug 8, 2017
@ny0m ny0m changed the title Uppdate problem-builder xblock install version Update problem-builder xblock install version Aug 8, 2017
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Aug 8, 2017

@bmedx can you please help us review/merge this if the build is green?

@bradenmacdonald bradenmacdonald changed the title Update problem-builder xblock install version Update problem-builder xblock install version (PLAT-1644) Aug 8, 2017
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @bradmerlin

  • I tested this on my devstack using the PR instructions.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation - just a version bump

@bradenmacdonald
Copy link
Contributor

@bmedx @edx/devops Argh, I think we'll need to revert this ASAP. I just realized that this version bump goes from 2.6.5 -> 2.6.10, which includes some hefty migrations that need to be handled very carefully, which have been stalled for months - see https://github.com/edx/edx-platform/pull/14327 and the original TNL-5932 ticket.

I opened #15783 to revert this if that is the case.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Thursday, August 10, 2017.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@ny0m ny0m deleted the bradmerlin/problem-builder-version-bump branch August 14, 2017 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants