Convert tabs to use RESTful API #1675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
As long as you're fixing whitespace, I don't think this is yet compliant w/ our guidelines (I could be wrong). I think we're supposed to do these like:
def check_import( -----self, module_store, ... ):
which I find a bit disturbing. (---- s/b spaces but formatted wrong in output)
Author
There was a problem hiding this comment.
In this particular case, I find the recommended formatting much more difficult to read. And what I have doesn't produce any pylint/pep8 warnings.
Contributor
|
👍 |
STUD-850
cahrens
pushed a commit
that referenced
this pull request
Nov 21, 2013
Convert tabs to use RESTful API
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test creation, deletion, modification, and re-ordering of static pages (tabs) in Studio.
@dmitchell Please review.