prevent failure when module does not have a data field

[mulby]

This raised an AttributeError when I tried to retrieve a vertical or a course using the REST API.

Reviewers: @dmitchell, @singingwolfboy

[mulby]

Is there already a bank of tests for the REST API that I could add a test to?

[mulby]

@dmitchell @singingwolfboy - bump

[dmitchell]

I hope to get to this today. Getting internet at home and going to doctors
shortened my work hours since Friday (I thought I'd have internet over the
weekend to catch up, but installation failed. All set now though!)

On Mon, Nov 18, 2013 at 11:49 AM, Gabe Mulley notifications@github.comwrote:

@dmitchell https://github.com/dmitchell @singingwolfboyhttps://github.com/singingwolfboy- bump

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1682#issuecomment-28715142
.

[singingwolfboy]

This seems reasonable to me. I don't know anything about a bank of REST API tests, unfortunately -- but @dmitchell might know.

[dmitchell]

👍

as to a bank of tests, we've been changing existing tests to the new api or making one test file per view file. It would be great if you could add a test to cms.djangoapps.contentstore.tests.test_item.ItemTest (I note that I neglected to do so.)

[sarina]

Hey what's going on with this PR? It's been untouched for 14 days.

[dmitchell]

I think Gabe should merge it.

[mulby]

I've been 100% focused on the datajam lately, originally needed this for it, turns out we don't really, so I shifted my focus elsewhere. I was planning on adding tests for it after we get the datajam stuff squared away and then merging it. I can merge now, though, if that's helpful.

[sarina]

I'm just trying to clear out old PRs. Do what makes sense for you.

[singingwolfboy]

@mulby Now that the datajam is done, are you ready to merge this?

[mulby]

Alright, I've added a test. Didn't invest too much in surrounding coverage, however, this test does cover the change. When/if this passes the CI tests, I'll merge it in to master.