Skip to content

Conversation

@flowerhack
Copy link
Contributor

Not sure who to tag for something like this, so let me know if there's anyone more advisable! @dianakhuang @nedbat

LMS-1507

@dianakhuang
Copy link
Contributor

Looks like you need to make sure that the password reset tests are also updated. 😉

@wedaly
Copy link
Contributor

wedaly commented Nov 19, 2013

@flowerhack All the unit tests are passing, but the documentation tests are failing. I have to admit I've never seen that happen before. Here's the traceback from the console: https://gist.github.com/wedaly/7538145

Does the command rake builddocs succeed locally?

@flowerhack
Copy link
Contributor Author

Heh. I actually noticed this as I was leaving today and planned to ask you about it in the morning, as I thought it was odd too. I'll let you know tomorrow about rake builddocs.

@flowerhack
Copy link
Contributor Author

@nedbat @dianakhuang

@nedbat
Copy link
Contributor

nedbat commented Nov 19, 2013

👍

@dianakhuang
Copy link
Contributor

👍 🚢

flowerhack pushed a commit that referenced this pull request Nov 19, 2013
@flowerhack flowerhack merged commit bc4ebfd into master Nov 19, 2013
@flowerhack flowerhack deleted the flowerhack/fix/password-reset-messages branch November 19, 2013 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants