Update course_navigation.html

[puntxo]

The tab names are not being translated

[singingwolfboy]

Thanks for the pull request! Before we can merge it, we need a signed individual contributor agreement, as specified in the CONTRIBUTING file. You should also add another commit ot this pull request that adds your name and email to the AUTHORS file.

[puntxo]

Thank you David, I've done what you told me. Sorry about not reading all the instructions before.

I've changed my e-mail address in my GitHub profile and now it is jorts@upv.es, which is the University e-mail. I think it is more appropriate than my personal one.

Best regards

Javier Orts Peñarrocha
Área de Sistemas de Información y Comunicaciones
Universidad Politécnica de Valencia
e-mail: jorts@upv.esmailto:jorts@upv.es
Tel.: 963879074 ext.: 78752

De: David Baumgold <notifications@github.commailto:notifications@github.com>
Responder a: edx/edx-platform <reply@reply.github.commailto:reply@reply.github.com>
Fecha: viernes, 22 de noviembre de 2013 17:41
Para: edx/edx-platform <edx-platform@noreply.github.commailto:edx-platform@noreply.github.com>
CC: Javier Orts <puntxo@gmail.commailto:puntxo@gmail.com>
Asunto: Re: [edx-platform] Update course_navigation.html (#1748)

Thanks for the pull request! Before we can merge it, we need a signed individual contributor agreementhttp://code.edx.org/individual-contributor-agreement.pdf, as specified in the CONTRIBUTINGhttps://github.com/edx/edx-platform/blob/master/CONTRIBUTING.md file. You should also add another commit ot this pull request that adds your name and email to the AUTHORShttps://github.com/edx/edx-platform/blob/master/AUTHORS file.

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/1748#issuecomment-29081675.

[singingwolfboy]

@puntxo Great, thanks! Can you also add another commit to this branch, adding yourself to the AUTHORS file?

[singingwolfboy]

If the tab.name string is already in the localization file, this should correctly translate it -- however, by calling gettext on a variable, you're making it impossible to extract the translation string into a localization file. Fixing this correctly would require some further work -- treating the tab.name variable as a key into a dictionary of translatable strings, perhaps. However, this is no worse than it was before, and slightly better, so I'm going to merge it anyway.

@puntxo Thanks for your contribution!