Do not pull into master: Changes to Stanford CME registration form #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes bring the form to Nov 12 specs.
Contributor
Author
|
@nparlante: whenever you have a few minutes. |
Contributor
There was a problem hiding this comment.
I would consider writing a comment up here saying what this thing does. Also, it's missing the newline on the last line.
Contributor
Author
There was a problem hiding this comment.
Nick, this is the auto-generated migration file so generally we don't touch it.
Contributor
|
LGTM I'm guessing the test failures have to do with the -west- targeting of this this. Some of the failures seem to have to do with data, and some are just timeouts. Hmm, I'm going to write LGTM a second time, in case my comment is messing up the github auto parser thingy. |
Contributor
|
LGTM |
Contributor
Author
|
@nparlante Yes, the test failures are edx-west repo related. Thank you for the comments. |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 24, 2017
* Add font-style normal. openedx#1790 * Mod error message when disable to register student-self with input status. openedx#1787 * Mod biz-menu style height to min-height. openedx#1793 * Fix review(TYPO).
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to CME registration form
These changes bring the form to Nov 12 specs.