Skip to content

Conversation

@polesye
Copy link
Contributor

@polesye polesye commented Nov 27, 2013

Add possibility to navigate through the hints via arrow keys.

Keyboard Support:
If focus is on the hint button:

  • Enter: Open or close hint popup. Select last focused hint item if opening.
  • Space: Open or close hint popup. Select last focused hint item if opening.

If focus is on a hint item:

  • Left arrow: Select previous hint item.
  • Up arrow: Select previous hint item.
  • Right arrow: Select next hint item.
  • Down arrow: Select next hint item.

Goal (composite):

Authors SHOULD ensure that a composite widget exist as a single navigation stop within the larger navigation system of the web page. Once the composite widget has focus, authors SHOULD provide a separate navigation mechanism for users to navigate to elements that are descendants or owned children of the composite element.

Related links:

@jmclaus , @auraz , @frrrances please review.

@ghost ghost assigned jmclaus Nov 27, 2013
@auraz
Copy link
Contributor

auraz commented Nov 27, 2013

👍 Please update ticket in Jira with all links that you've posted here.

@polesye
Copy link
Contributor Author

polesye commented Nov 27, 2013

@auraz done.

@jmclaus
Copy link

jmclaus commented Nov 27, 2013

@polesye Nice job! It would be great if pressing on the ESC key would hide the help popup and give focus back to the help button. Right now, the only way to collapse the list is to tab forward (gives focus to = button) or backwards (gives focus to help button).

@jmclaus
Copy link

jmclaus commented Nov 27, 2013

@polesye When using VoiceOver, the elements of the help popup are read twice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend adding one more list item at the top with the sr class to give instructions on keyboard navigation, maybe something like this:

<li class="sr" id="hint-instructions" tabindex="-1"><p>Use the arrow keys to navigate the tips or use the tab key to return to the calculator</p></li>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done using aria-describedby attribute.

@frrrances
Copy link
Contributor

Great improvement! Looks good to me. I just added one comment which is not a blocker about adding some instructions. 👍

@polesye
Copy link
Contributor Author

polesye commented Nov 28, 2013

It would be great if pressing on the ESC key would hide the help popup and give focus back to the help button. Right now, the only way to collapse the list is to tab forward (gives focus to = button) or backwards (gives focus to help button).

@jmclaus done.

@polesye
Copy link
Contributor Author

polesye commented Nov 28, 2013

When using VoiceOver, the elements of the help popup are read twice.

@jmclaus Strange. It works fine for me.

@jmclaus
Copy link

jmclaus commented Dec 2, 2013

@polesye Great, Esc key works nicely now. 👍 to merge.

polesye added a commit that referenced this pull request Dec 2, 2013
Improve calculator's tooltip accessibility.
@polesye polesye merged commit 45d373c into master Dec 2, 2013
@polesye polesye deleted the anton/calculator-hint-a11y branch December 2, 2013 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants