-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Improve calculator's tooltip accessibility. #1798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 Please update ticket in Jira with all links that you've posted here. |
|
@auraz done. |
|
@polesye Nice job! It would be great if pressing on the ESC key would hide the help popup and give focus back to the help button. Right now, the only way to collapse the list is to tab forward (gives focus to = button) or backwards (gives focus to help button). |
|
@polesye When using VoiceOver, the elements of the help popup are read twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend adding one more list item at the top with the sr class to give instructions on keyboard navigation, maybe something like this:
<li class="sr" id="hint-instructions" tabindex="-1"><p>Use the arrow keys to navigate the tips or use the tab key to return to the calculator</p></li>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done using aria-describedby attribute.
|
Great improvement! Looks good to me. I just added one comment which is not a blocker about adding some instructions. 👍 |
@jmclaus done. |
@jmclaus Strange. It works fine for me. |
|
@polesye Great, Esc key works nicely now. 👍 to merge. |
Improve calculator's tooltip accessibility.
Add possibility to navigate through the hints via arrow keys.
Keyboard Support:
If focus is on the hint button:
If focus is on a hint item:
Goal (composite):
Related links:
@jmclaus , @auraz , @frrrances please review.