Valera/lti graded additional tests 2 #1811
Conversation
ghost
assigned
There was a problem hiding this comment.
Did you mean to comment this line out? Perhaps it should just be removed.
|
@auraz , @jmclaus , @singingwolfboy please finish with reviewing this PR. If all OK, give your thumbs up. I will squash all commits into 1, rebase, and merge. |
|
@valera-rozuvan Sure but could you please look at my comments first? Thanks. |
|
@jmclaus Sorry. = ) Forgot the one "this.el.find('.lti') should be cached.". Doing now. |
|
@valera-rozuvan Good. And your call on using requireJS or not. |
There was a problem hiding this comment.
https://github.com/edx/edx-platform/wiki/Python-Guidelines
For unused args, you can prefix the arguments with _ to mark them as unused (as convention), and pylint will accept that.
|
@jmclaus I have decided to use RequireJS. You are right that we should try to standardize the process of writing JavaScript code for XModules. |
|
please ensure how this works in real mode with sandbox server |
|
@auraz I fixed issues. |
|
@auraz, fixed. please continue review. |
There was a problem hiding this comment.
If you leave the scheme off the URL, the browser will use either http or https, as appropriate for the page. http://stackoverflow.com/questions/4831741/can-i-change-all-my-http-links-to-just
There was a problem hiding this comment.
Scheme is used in oauth signing, and current oauthlib implementation throws Exception, if scheme is not specified (https://github.com/idan/oauthlib/blob/master/oauthlib/oauth1/rfc5849/signature.py#L136)
|
👍 |
Valera/lti graded additional tests 2
Includes new and updated Python tests for the LTI module. LTI must use HTTPS for
lis_outcome_service_url.BLD-564
Reviewers