Skip to content

settings.MITX_FEATURES => settings.FEATURES #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
singingwolfboy merged 2 commits into from
Dec 4, 2013
Merged

settings.MITX_FEATURES => settings.FEATURES #1827

singingwolfboy merged 2 commits into from
Dec 4, 2013

Conversation

@singingwolfboy
Copy link
Contributor

@singingwolfboy singingwolfboy commented Dec 3, 2013

Part 2 of #1815

@gwprice @feanil

@feanil
Copy link
Contributor

feanil commented Dec 3, 2013

This should also include a change log entry as it will affect anyone running an instance of the platform that is overriding the features dict.

gwprice
gwprice reviewed Dec 3, 2013
View reviewed changes
lms/djangoapps/shoppingcart/tests/test_context_processor.py Outdated
Copy link

@gwprice gwprice Dec 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@singingwolfboy
Copy link
Contributor Author

singingwolfboy commented Dec 3, 2013

Tests are now passing.

@feanil: I've added a changelog entry. Can you make the appropriate change to the configuration repo when this lands?

@gwprice: Can you take another look, and hopefully provide a thumbs-up?

@gwprice
Copy link

gwprice commented Dec 3, 2013

It would actually be nice to provide a transition period for the environment variable by doing ENV_TOKENS.get('FEATURES', ENV_TOKENS.get('MITX_FEATURES', {})). This would avoid the need for close coordination with the configuration repo.

@singingwolfboy
Fall back on MITX_FEATURES env variable if FEATURES isn't found
79815ac 
For a smoother transition to the new world
@singingwolfboy
Copy link
Contributor Author

singingwolfboy commented Dec 3, 2013

@gwprice Done.

@gwprice
Copy link

gwprice commented Dec 3, 2013

👍

feanil referenced this pull request in openedx-unsupported/configuration Dec 3, 2013
@feanil
Remove MITX from the name of the features dict.
eab751a 
This is to correspond to the same fix in the edx platform.
https://github.com/edx/edx-platform/pull/1827
@feanil feanil mentioned this pull request Dec 3, 2013
Merged
@feanil
Copy link
Contributor

feanil commented Dec 3, 2013

@gwprice good idea,

opened https://github.com/edx/configuration/pull/518 to match the new configuration to this since the sandboxes use that along with master, gonna wait to update our currently running configurations until after this is released, which seems like it will not be for a week and a half.

changes look good.

singingwolfboy added a commit that referenced this pull request Dec 4, 2013
@singingwolfboy
Merge pull request #1827 from edx/db/remove-mitx-from-features
d1f3e3a 
settings.MITX_FEATURES => settings.FEATURES
@singingwolfboy singingwolfboy merged commit d1f3e3a into master Dec 4, 2013
@singingwolfboy singingwolfboy deleted the db/remove-mitx-from-features branch December 4, 2013 15:13
@snyk-bot snyk-bot mentioned this pull request Jan 4, 2021
Open
@arslanashraf7 arslanashraf7 mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@singingwolfboy @feanil @gwprice