jeff/feature-targeted-feedback

[jaericson]

@nparlante

Creating pull request for the "targeted feedback" feature on multiple choice questions.

This allows the author to have include targeted feedback for when students select an incorrect choice. Currently, the system only allows feedback blurbs that correspond to the correct answer. Targeted feedback will show up without the student needing to click the "Show Answer" button. There is also an option to change the explanation for the correct choice from a solution to targeted feedback. This essentially means that a student will see this automatically without clicking any buttons, and will also not see a green checkmark next to the correct answer until pressing the "Show Answer" button.

To try out, you set up a multiple choice problem with attribute targeted-feedback set to any value, or to always show the correct solution without the student needing to press a button or see the correct choice, set the value to alwaysShowCorrectChoiceExplanation. Then, you can provide targeted feedback by including a <targetedfeedback> element within a parent <targetedfeedbackset> element. The explantion-id attribute must match between the <choice> and the <targetedfeedback>.

Example XML:

<problem>
  <p>What is the correct answer?</p>
  <multiplechoiceresponse targeted-feedback="alwaysShowCorrectChoiceExplanation">
    <choicegroup type="MultipleChoice">
      <choice correct="false" explanation-id="feedback1">wrong-1</choice>
      <choice correct="false" explanation-id="feedback2">wrong-2</choice>
      <choice correct="true" explanation-id="feedbackC">correct-1</choice>
      <choice correct="false" explanation-id="feedback3">wrong-3</choice>
    </choicegroup>
  </multiplechoiceresponse>

  <targetedfeedbackset>
      <targetedfeedback explanation-id="feedback1">
      <div class="detailed-targeted-feedback">
          <p>Targeted Feedback</p>
          <p>This is the 1st WRONG solution</p>
      </div>
      </targetedfeedback>

      <targetedfeedback explanation-id="feedback2">
      <div class="detailed-targeted-feedback">
          <p>Targeted Feedback</p>
          <p>This is the 2nd WRONG solution</p>
      </div>
      </targetedfeedback>

      <targetedfeedback explanation-id="feedback3">
      <div class="detailed-targeted-feedback">
          <p>Targeted Feedback</p>
          <p>This is the 3rd WRONG solution</p>
      </div>
      </targetedfeedback>

      <targetedfeedback explanation-id="feedbackC">
      <div class="detailed-targeted-feedback-correct">
          <p>Targeted Feedback</p>
          <p>Feedback on your correct solution...</p>
      </div>
      </targetedfeedback>

  </targetedfeedbackset>

  <solution explanation-id="feedbackC">
  <div class="detailed-solution">
      <p>Explanation</p>
      <p>This is the solution explanation</p>
      <p>Not much to explain here, sorry!</p>
  </div>
  </solution>
</problem>

[jinpa]

This part of the description: "To try out, you set up a multiple choice problem with attribute targeted-feedback set to any value, or to always show the correct solution without the student needing to press a button or see the correct choice, set the value to alwaysShowCorrectChoiceExplanation. " leaves it a little unclear what the value should be if you don't want to always show the correct choice explanation. I tried setting it to "1", and that worked, but maybe a clearer description would be better?

Also: I suspect the PR comment isn't the ideal place for this end-user documentation - I'm guessing there should be a YAML file to serve as a template so this can be discoverable - @caesar2164 can show you how to make one of these. It could be called "Multiple choice with targeted feedback" or some such.

[jinpa]

I tried this and it seemed to work for me. For a future version, it'd be nice to have this accessible via the Markdown rather than just the XML, though I think it's ok for it to live w/ just the XML.

[jaericson]

Just rebased this branch so that commits from others aren't showing up anymore. Please checkout this branch anew if you want to test anything on it.

[nparlante]

It'd be nice to not run the query twice.

[nparlante]

@caesar2164 Hey Giulio -- could you check that the css strategy here is right?

[nparlante]

Notes for the future: Jane and I have a rough agreement that I'll add markdown support and a YAML file for this feature later, but not on this PR

[nparlante]

Ok, I rebased this down to one commit and --force to jam it back. It has the date of Jeff's oldest commit, but I had a quick discussion Joe and we decided that was ok.

[nparlante]

I'm going to close this one in favor of an umbrella PR of the shuffle feature and all of Jeff's stuff, staring with this: https://github.com/edx/edx-platform/pull/1995