Skip to content

Conversation

@singingwolfboy
Copy link
Contributor

Part 5 of #1815

@flowerhack
Copy link
Contributor

Looks good to me, so long as someone from analytics gives it a nod as well

@singingwolfboy
Copy link
Contributor Author

@rocha Can you take a look and verify that this looks good?

@mulby
Copy link
Contributor

mulby commented Dec 4, 2013

This generally looks fine to me, my only note / concern is that somebody somewhere is configuring the 'mitx' logger and expecting those settings to be inherited by all 'mitx.*' loggers. I'm not sure what our prod logger settings look like but we should be sure to update those settings as well (if necessary).

@rocha
Copy link
Contributor

rocha commented Dec 4, 2013

LGTM 🚀

In this case, the changes are not related to analytics. It is confusing because we have been using the term tracking logs when we should be using event tracking.

singingwolfboy added a commit that referenced this pull request Dec 4, 2013
Update logging.getLogger() calls to use edx instead of mitx
@singingwolfboy singingwolfboy merged commit beda1f8 into master Dec 4, 2013
@singingwolfboy singingwolfboy deleted the db/update-logging branch December 4, 2013 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants