Video: Update behavior of start/end time fields. #1873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
There was a problem hiding this comment.
@polesye Please use 4 spaces indentation throughout the file.
|
@ Nice work. 👍 |
Contributor
|
@polesye Found some strange behavior. |
Contributor
Author
|
@auraz Thanks. |
Contributor
|
👍 |
|
👍 |
Contributor
Author
cms/static/js/views/metadata.js
Outdated
Contributor
There was a problem hiding this comment.
Does not it actually look prettier?
var list = value.replace(/\s+/g, '').split(':');
list = _.map(list, function(num) { return Math.max(0, parseInt(num) || 0) } );
seconds = list.pop() + _.reduce(list, function(memo, num) {return memo + num * 60;}, 0)
Contributor
|
👍 |
|
@polesye 👍 |
polesye
added a commit
that referenced
this pull request
Dec 18, 2013
Video: Update behavior of start/end time fields.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
…openedx#1974) * Fix review. add custom logo settings openedx#1873 * Fix bugs. add custom logo settings openedx#1972 * Fix bugs. add custom logo settings openedx#1971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLD-506.
It should be possible to enter the start/end time as a string HH:MM:SS, and only have the field adjust after the user clicks away. If the user enters something like "1:35", we would interpret that as "00:01:35" after the user clicks away. However, while the user is entering text into the field, it should show the keys that the user was pressing. If the user enters something completely invalid, reset to 00:00:00.
@jmclaus, @auraz please review.