-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Consolidate user login and authentication code #18917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
99d8730 to
2756c04
Compare
2f8c51f to
2fb9b71
Compare
robrap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big step in the right direction. Thanks.
robrap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve of what I reviewed once tests are passing. Let me know if you need a re-review on any final changes.
7bc367c to
161ada0
Compare
161ada0 to
8cf4428
Compare
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Wednesday, September 19, 2018. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
FYI: @dianakhuang: Here is the refactor with a couple of small deletions. |
This PR consolidates the actively used code related to login/logout and user authentication in the platform - as a runway for future immediate work in this area.
Specifically: