Skip to content

Conversation

@nasthagiri
Copy link
Contributor

@nasthagiri nasthagiri commented Sep 12, 2018

This PR consolidates the actively used code related to login/logout and user authentication in the platform - as a runway for future immediate work in this area.

Specifically:

  • Renamed lms.djangoapps.student_account -> lms.djangoapps.user_authn (as a Django App Plugin)
    • bringing in URLs from lms/common.py into the user_authn app
  • Moved following views from lms.djangoapps.student_account -> common.djangoapps.student
    • password_change_request_handler
  • Moved following views from lms.djangoapps.student_account -> openedx.core.djangoapps.user_api
    • account_settings
  • Moved following views from common.djangoapps.student -> lms.djangoapps.user_authn
    • LogoutView
    • login_user
    • create_account
    • auto_auth
    • (kept email-related code in common.djangoapps.student for now)
  • Moved following from common.djangoapps.student -> openedx.core.djangoapps.oauth_dispatch
    • oauth token helpers
  • Deleted following unused views
    • verify_user_password (in common.djangoapps.student)
    • login_oauth_token (in common.djangoapps.student)

@nasthagiri nasthagiri force-pushed the arch/user-authn-app branch 7 times, most recently from 99d8730 to 2756c04 Compare September 12, 2018 19:31
@nasthagiri nasthagiri requested a review from robrap September 12, 2018 20:17
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big step in the right direction. Thanks.

Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve of what I reviewed once tests are passing. Let me know if you need a re-review on any final changes.

@nasthagiri nasthagiri force-pushed the arch/user-authn-app branch 4 times, most recently from 7bc367c to 161ada0 Compare September 15, 2018 07:00
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@nasthagiri nasthagiri merged commit e2ff1ec into master Sep 15, 2018
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Wednesday, September 19, 2018.

@nasthagiri nasthagiri deleted the arch/user-authn-app branch September 19, 2018 12:29
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@robrap
Copy link
Contributor

robrap commented Sep 21, 2018

FYI: @dianakhuang: Here is the refactor with a couple of small deletions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants