Stop forcing video player’s speeds widget width #1904
Conversation
When translating the “Speed” label using a longer word, the speeds button gets really ugly. The dropdown and the button will not always have equal widths, but it’s better than having the text overlap the other buttons.
ghost
assigned
|
@Lyla-Fischer can you suggest some blades team members to review this open source pull request? |
|
@Lyla-Fischer - it would make sense to have a blades team member review in case there are other cases or logic for display are missing. 👍 |
|
This is also UI-related, so @frrrances might want to take a look as well. |
|
If @marcotuts says okay, I don't need additional review... I'm cool with it. |
|
@tusbar have you added yourself to See section "Becoming a Contributor" in https://github.com/edx/edx-platform/blob/master/CONTRIBUTING.md for more. |
|
@tusbar 👍 |
|
@sarina I was in it, but the PR was reverted. I’ll create a separate PR to add myself in it. |
|
@valera-rozuvan can you make sure on our next release that you vouch for this change on staging (since this is an open source PR)? Thanks. @tusbar ah I see. I will merge this then, but please make sure when things are settled with your other PRs that you get yourself added to |
Stop forcing video player’s speeds widget width
|
@sarina OK. |
|
@sarina yes, thanks! 👍 |
* Fix bug 'self'. openedx#1904 * Add validation of email subject and body. openedx#1904 * Mod to get first record, if duplicate. openedx#1903 * Fix margin. openedx#1905 * Fix scrollbar and skip bok-choy. openedx#1906
6 participants
When translating the “Speed” label using a longer word, the speeds
button gets really ugly. The dropdown and the button will not always
have equal widths, but it’s better than having the text overlap the
other buttons.