Skip to content

Conversation

@e0d
Copy link
Contributor

@e0d e0d commented Dec 11, 2013

@cpennington @jarv @feanil

@jtauber for the new requirement

The creates a new environment that inherits everything from aws.py and does the following

  • prepends the doglow middleware to the inherited list of middleware classes.
  • configures dog slow.

This PR does not integrate dogslow directly into aws.py as I'd like to run in selectively for a while before blessing it.

We should also change the logging directory, but that will require an additional PR against the config repo to create a sensible directory and/or integrate dogslow with rsyslog.

@cpennington
Copy link
Contributor

I'd rather have dogslow being an option in aws.py, rather than being a separate environment file. The proliferation of environment files is unfortunate, in my mind.

@e0d
Copy link
Contributor Author

e0d commented Dec 11, 2013

Seems reasonable, but what scheme do we use for optionally including it? Environment variable?

@cpennington
Copy link
Contributor

It's aws.py, so read it out of env.json. Have a single variable that controls whether it's on or off, and then more variables for the more specific configuration as needed.

@jtauber
Copy link
Contributor

jtauber commented Dec 12, 2013

LGPL is fine.

@e0d
Copy link
Contributor Author

e0d commented Dec 17, 2013

@cpennington I'm going to close this for now. I don't think more JSON config is the way to go, but take your point about the proliferation of settings files.

@e0d e0d closed this Dec 17, 2013
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants