Add email configuration to cms/envs/aws.py #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the django default settings.
This allows emails to be sent by Studio.
Contributor
Contributor
|
Someone in ops should verify, but it looks fine to me. |
Contributor
|
Defaults are good and we don't use the SMTP backend in production so changes look good to me. |
Contributor
|
Thanks --- merging (but I'm going to ask one of you to verify this doesn't affect staging when it makes it into the release branch) |
sarina
added a commit
that referenced
this pull request
Dec 12, 2013
Add email configuration to cms/envs/aws.py
tusbar
added a commit
to IONISx/edx-platform
that referenced
this pull request
Dec 13, 2013
Fix bug introduced by openedx#1919: usage of not-yet-defined AUTH_TOKENS dict.
Contributor
|
@jzoldak sorry about that. Am open to suggestions on different ways to test things - maybe config changes should always be tested by doing a sandbox deploy? |
Contributor
|
@sarina I agree. Any changes to common.py, aws.py, etc. should be tested with a sandbox deploy. Let's communicate that out to our teams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows emails to be sent by Studio.
I enabled the creator group (using ENABLE_CREATOR_GROUP), and Studio needs to be able to send emails. So emails need to be configured.