Add ignore patterns for staticfiles to avoid processing symlink dirs #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
wedaly
pushed a commit
that referenced
this pull request
Dec 16, 2013
Add ignore patterns for staticfiles to avoid processing symlink dirs
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For complicated reasons, js-test-tool requires that we create symlinks in edx-platform for JavaScript dependencies. These symlinks were being followed when Django collected staticfiles, resulting in staticfiles being collected multiple times.
This PR adds the symlinks to
STATICFILES_IGNORE_PATTERNSto skip those directories, which should speed up asset collection (especially on the Vagrant images, where disk writes to shared directories are expensive).Ideally we wouldn't have to use symlinks at all, but that's a task for another day :)
Suggested reviewers: @cpennington @singingwolfboy