Create explicit Locations. #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of STUD-1030
Contributor
There was a problem hiding this comment.
Because there's an index on '_id.category' but not the combo of it w/ tag, it's better to do these as
Location(None, None, None, 'course', None), but that's arguably out of scope for this PR.
Author
There was a problem hiding this comment.
Since it is a test, I don't think performance is a concern.
Contributor
|
👍 |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
* Fix gap of biz-menu. openedx#1939 * Fix message to save mail-template. openedx#1938 * Fix message to send test-mail. openedx#1934 * Fix current menu of mail management. openedx#1955
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of STUD-1030
I am leaving URL forms alone-- is that OK? They seem to exist mostly in tests, for places where a serialized version of a Location is expected.
@dmitchell Here is the 2nd one to review. It contains the rest of the change (common and LMS).