-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Anton/allow arbitrary regex in stringresponse #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well fix "areintended" while you're here.... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: Might as well fix "areintended" while you're here.... :)
|
@nedbat I've addressed all your comments. Please continue review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use camelCase (firstAnswer instead first_answer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
|
@polesye all your comments are addressed. |
|
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add these four files, please. They are due to a known problem on master, but should not be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were added accidentally through negligence. Thanks, fixed: "Don't add these four files, please. "
|
I can finish the review when the semantics of the regex match have been finished. |
|
@nedbat All your comments are addressed, please continue review. |
|
👍 |
…ngresponse Anton/allow arbitrary regex in stringresponse
This is for https://edx-wiki.atlassian.net/browse/BLD-475: Allow arbitrary regex inside of string response and updates for multiple answers for string response.
Add mode to markdown editor: if first answer is started with | -> that will be regexp.
@Lyla-Fischer @polesye @nedbat Please review.
@srpearce this PR contains documentation.